Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Adjustments and Documentation #1319

Merged
merged 17 commits into from
Aug 7, 2019
Merged

CLI Adjustments and Documentation #1319

merged 17 commits into from
Aug 7, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Aug 6, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Closes #1266
Closes #1267
Closes #1268

Removes the auth add command in favor of auth login. Removes the empty summarize group. run --logs now auto exits on flow completion. Adds general documentation for CLI.

Why is this PR important?

Removing unused CLI cruft and adding CLI documentation are great steps for user clarity

@joshmeek joshmeek added docs cli Related to the Prefect CLI labels Aug 6, 2019
@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #1319 into master will decrease coverage by 0.1%.
The diff coverage is 62.5%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor typo fixes, but otherwise this is awesome! I think this sheds a lot of light on Cloud's API that people will find interesting.

docs/guide/cloud_concepts/cli.md Outdated Show resolved Hide resolved
docs/guide/cloud_concepts/cli.md Outdated Show resolved Hide resolved
docs/guide/cloud_concepts/cli.md Outdated Show resolved Hide resolved
docs/guide/cloud_concepts/cli.md Outdated Show resolved Hide resolved
docs/guide/cloud_concepts/cli.md Show resolved Hide resolved
joshmeek and others added 6 commits August 7, 2019 09:12
Co-Authored-By: Chris White <chris@prefect.io>
Co-Authored-By: Chris White <chris@prefect.io>
Co-Authored-By: Chris White <chris@prefect.io>
Co-Authored-By: Chris White <chris@prefect.io>
@joshmeek joshmeek merged commit 98aac00 into master Aug 7, 2019
@joshmeek joshmeek deleted the cli_adjustments branch August 7, 2019 15:59
abrookins pushed a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the Prefect CLI docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI run cloud --logs needs exit Add login CLI command Add CLI Documentation
2 participants