-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit of development section docs #13247
Edit of development section docs #13247
Conversation
👷 Deploy request for prefect-docs-preview pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Minor edits.
Thanks for the improvements! Incorporated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Man, in an attempt to merge some docs changes on main in this PR I really messed it up and I'm not quite sure how to un-mess it up, my apologies. Anyone know how to get this back to the state it was in prior to 10e9d56? |
No worries, it happens. I'm not a git wizard though, so open to if anyone
on your team has any ideas.
…On Thu, May 16, 2024 at 7:46 AM Bill Palombi ***@***.***> wrote:
Man, in an attempt to merge some docs changes on main in this PR I really
messed it up and I'm not quite sure how to un-mess it up, my apologies.
Anyone know how to get this back to the state it was in prior to 10e9d56
<10e9d56>
?
—
Reply to this email directly, view it on GitHub
<#13247 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A76PPBM3NSXUCNAFTXFXLI3ZCTBCTAVCNFSM6AAAAABHHY7N42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGQ2DSNZZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dave Nuñez
Principal
Stellar Docs
4158139912 <8143801358>
***@***.***
|
4cc8d28
to
10e9d56
Compare
Well, that made it worse. I'll try and rebuild this PR with cherry-pick, the data is still here, just need to apply it in the right order. |
10e9d56
to
d2a7743
Compare
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Updated Marvin links.
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
Working around formatting issue.
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
d2a7743
to
9441fd1
Compare
Okay, it's back @billpalombi . I did have some gnarly git conflicts, I tried to do my best to get the right one, but we should go back through this PR and make sure it's what we want. @stellardave I 'force-pushed' this branch a lot, so if you want to change it you'll want to do a |
Thanks a ton @bunchesofdonald! This looks good to me @stellardave, but worth getting your eyes on it once more before we merge it. |
Thanks @bunchesofdonald! Looks good to me. @billpalombi I'll review after it lands to make doubly sure it looks okay. |
Updated the Development section. Key edits include: