Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit of development section docs #13247

Merged
merged 39 commits into from
May 17, 2024

Conversation

stellardave
Copy link
Collaborator

Updated the Development section. Key edits include:

  • Cutting overexplanations
  • Typo fixes
  • Being more authoritative and actionable
  • Moving to second person (you) instead of first person plural (we)

@stellardave stellardave requested a review from a team as a code owner May 5, 2024 14:44
Copy link

netlify bot commented May 5, 2024

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 453c9cb

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Minor edits.

docs/guides/creating-interactive-workflows.md Outdated Show resolved Hide resolved
docs/guides/creating-interactive-workflows.md Outdated Show resolved Hide resolved
docs/guides/creating-interactive-workflows.md Outdated Show resolved Hide resolved
docs/guides/creating-interactive-workflows.md Outdated Show resolved Hide resolved
docs/guides/creating-interactive-workflows.md Outdated Show resolved Hide resolved
docs/guides/runtime-context.md Outdated Show resolved Hide resolved
docs/guides/webhooks.md Outdated Show resolved Hide resolved
docs/guides/webhooks.md Outdated Show resolved Hide resolved
docs/recipes/recipes.md Outdated Show resolved Hide resolved
docs/recipes/recipes.md Outdated Show resolved Hide resolved
@stellardave
Copy link
Collaborator Author

Thanks for the improvements! Incorporated.

Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

docs/guides/creating-interactive-workflows.md Outdated Show resolved Hide resolved
docs/guides/ci-cd.md Outdated Show resolved Hide resolved
@billpalombi
Copy link
Contributor

Man, in an attempt to merge some docs changes on main in this PR I really messed it up and I'm not quite sure how to un-mess it up, my apologies. Anyone know how to get this back to the state it was in prior to 10e9d56?

@stellardave
Copy link
Collaborator Author

stellardave commented May 17, 2024 via email

@bunchesofdonald
Copy link
Contributor

Well, that made it worse. I'll try and rebuild this PR with cherry-pick, the data is still here, just need to apply it in the right order.

stellardave and others added 24 commits May 17, 2024 10:37
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Updated Marvin links.
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
Working around formatting issue.
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
@bunchesofdonald
Copy link
Contributor

Okay, it's back @billpalombi . I did have some gnarly git conflicts, I tried to do my best to get the right one, but we should go back through this PR and make sure it's what we want.

@stellardave I 'force-pushed' this branch a lot, so if you want to change it you'll want to do a git pull before making any changes, or if you already have staged changes you'll want to pull with rebase.

@billpalombi
Copy link
Contributor

Thanks a ton @bunchesofdonald!

This looks good to me @stellardave, but worth getting your eyes on it once more before we merge it.

@stellardave
Copy link
Collaborator Author

Thanks @bunchesofdonald!

Looks good to me. @billpalombi I'll review after it lands to make doubly sure it looks okay.

@billpalombi billpalombi merged commit 1f4eeb3 into PrefectHQ:main May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants