Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit review of Execution section #13253

Merged
merged 28 commits into from
May 16, 2024

Conversation

stellardave
Copy link
Collaborator

Edited entire section for clarity and consistency.

@stellardave stellardave requested a review from a team as a code owner May 6, 2024 05:33
Copy link

netlify bot commented May 6, 2024

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2b032d3

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor edits.

docs/guides/big-data.md Outdated Show resolved Hide resolved
docs/guides/big-data.md Outdated Show resolved Hide resolved
docs/guides/big-data.md Outdated Show resolved Hide resolved
docs/guides/dask-ray-task-runners.md Outdated Show resolved Hide resolved
docs/guides/dask-ray-task-runners.md Outdated Show resolved Hide resolved
docs/guides/logs.md Outdated Show resolved Hide resolved
docs/guides/logs.md Outdated Show resolved Hide resolved
docs/guides/logs.md Outdated Show resolved Hide resolved
docs/guides/logs.md Outdated Show resolved Hide resolved
docs/guides/moving-data.md Outdated Show resolved Hide resolved
@discdiver discdiver self-requested a review May 6, 2024 12:48
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions clarifying the Ray install section.


1. Make sure the `prefect-ray` collection is installed by running `pip install prefect-ray`.
2. In your flow code, import `RayTaskRunner` from `prefect_ray.task_runners`.
3. Assign it as the task runner when the flow is defined using the `task_runner=RayTaskRunner` argument.

!!! warning "Ray environment limitations"
While we're excited about parallel task execution via Ray to Prefect, there are some inherent limitations with Ray you should be aware of:
While we're excited about parallel task execution through Ray to Prefect, there are some inherent limitations with Ray:

- Support for Python 3.11 is [experimental](https://docs.ray.io/en/latest/ray-overview/installation.html#install-nightlies).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Ray currently officially supports x86_64, aarch64 (ARM) for Linux, and Apple silicon (M1) hardware. 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding language directly from the Ray website.

docs/guides/dask-ray-task-runners.md Outdated Show resolved Hide resolved
stellardave and others added 15 commits May 6, 2024 11:02
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Thanks for the catch!

Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Jeff Hale <discdiver@users.noreply.github.com>
Co-authored-by: Bill Palombi <bill.palombi@gmail.com>
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@billpalombi billpalombi merged commit fba82ce into PrefectHQ:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants