Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Docker storage not respecting user-provided image names #1335

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Aug 8, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Fixes bug we saw in our exercise.

joshmeek
joshmeek previously approved these changes Aug 8, 2019
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #1335 into master will not change coverage.
The diff coverage is 100%.

@cicdw cicdw merged commit 384870b into master Aug 8, 2019
@cicdw cicdw deleted the fix-docker branch August 8, 2019 18:46
abrookins pushed a commit that referenced this pull request Mar 15, 2022
Use caching and nvm file support for setup-node GH action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants