Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes block auto-instrumentation #13407

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

chrisguidry
Copy link
Collaborator

Here we're explicitly emitting the loaded events (note that the name is
slightly changing to ....loaded instead of ....load.called), but otherwise
removing all of the other auto-instrumentation from blocks. This will reduce
the Prefect-generated event load/noise, while simultaneously helping with one
blocker to the Pydantic v2 upgrade.

Here we're explicitly emitting the `loaded` events (note that the name is
slightly changing to `....loaded` instead of `....load.called`), but otherwise
removing all of the other auto-instrumentation from blocks.  This will reduce
the Prefect-generated event load/noise, while simultaneously helping with one
blocker to the Pydantic v2 upgrade.
@chrisguidry chrisguidry requested a review from a team as a code owner May 16, 2024 15:55
@chrisguidry chrisguidry merged commit 217bb35 into main May 16, 2024
44 checks passed
@chrisguidry chrisguidry deleted the de-instrument-block-methods branch May 16, 2024 16:15
chrisguidry added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants