Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove infrastructure blocks from main #13424

Merged
merged 2 commits into from
May 17, 2024
Merged

Remove infrastructure blocks from main #13424

merged 2 commits into from
May 17, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented May 17, 2024 •
edited
Loading

Removes the Process, DockerContainer, and KubernetesJob infrastructure blocks

Closes #13359

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

desertaxle
desertaxle commented May 17, 2024
View reviewed changes
src/prefect/cli/kubernetes.py
Comment on lines -1 to -3
"""
Command line interface for working with Prefect on Kubernetes
"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this file because the recommended way to run the server/worker is via our published Helm chart.

desertaxle
desertaxle commented May 17, 2024
View reviewed changes
src/prefect/utilities/dockerutils.py
Comment on lines +30 to +33
CONTAINER_LABELS = {
"io.prefect.version": prefect.__version__,
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from prefect.infrastructure.container

@desertaxle desertaxle marked this pull request as ready for review May 17, 2024 10:20
@desertaxle desertaxle requested review from zangell44 and a team as code owners May 17, 2024 10:20
chrisguidry
chrisguidry approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@desertaxle desertaxle merged commit b0556cf into main May 17, 2024
25 checks passed
@desertaxle desertaxle deleted the remove-infra-blocks branch May 17, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44

@serinamarie serinamarie Awaiting requested review from serinamarie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove infrastructure blocks from the main branch
2 participants
@desertaxle @chrisguidry