Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce False case for flow run id is null #13464

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

zangell44
Copy link
Collaborator

@zangell44 zangell44 commented May 20, 2024

This PR fixes a bug @znicholasbrown found when trying to filter only for tasks that are contained within a flow run.

See also https://github.com/PrefectHQ/nebula/pull/7809.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@zangell44 zangell44 added the fix A fix for a bug in an existing feature label May 20, 2024
@zangell44 zangell44 requested a review from a team as a code owner May 20, 2024 14:37
@chrisguidry
Copy link
Collaborator

I might like to see the regression test for this

@zangell44 zangell44 merged commit 11aca26 into main May 21, 2024
17 of 25 checks passed
@zangell44 zangell44 deleted the fix-task-run-fr-id-filter branch May 21, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants