Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bye bye old engine #13542

Merged
merged 9 commits into from
May 23, 2024
Merged

Bye bye old engine #13542

merged 9 commits into from
May 23, 2024

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented May 23, 2024

Removes as much as I safely could of the old engine code, including the experimental setting.

The remaining functions in this file are seemingly used by the task scheduling flag, but I'm 99% sure that's subsumed by the new engine now. I didn't want to disrupt too much by removing them in this PR though (cc: @zzstoatzz @abrookins )

@cicdw cicdw requested a review from a team as a code owner May 23, 2024 17:19
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cicdw cicdw merged commit f3d9ffd into main May 23, 2024
25 checks passed
@cicdw cicdw deleted the bye-bye-old-engine branch May 23, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants