Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_state #13569

Merged
merged 2 commits into from
May 25, 2024
Merged

Remove is_state #13569

merged 2 commits into from
May 25, 2024

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented May 24, 2024

The is_state utility exists for backwards-compatible checks of historic server-defined State objects, and is no longer needed.

Due to threading, calling this function accounts for 7% of new task engine overhead (!)

@jlowin jlowin requested a review from a team as a code owner May 24, 2024 22:36
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice!

@jlowin jlowin merged commit 2df37e6 into main May 25, 2024
25 checks passed
@jlowin jlowin deleted the remove-is-state branch May 25, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants