migrate prefect-gcp to pydantic 2
#13650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
commented
May 29, 2024
zzstoatzz
commented
May 30, 2024
| @@ -48,6 +42,7 @@ def _result_sync(func, *args, **kwargs): | |||
|
|
|||
|
|
|||
| @task | |||
| @sync_compatible | |||
There was a problem hiding this comment.
these are to maintain the interface since async flows were imported and used as if they were sync due to 2.x engine mechanics
desertaxle
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync_compatiblewas restored today by #13627, which allowed us to be less destructive in our migration ofprefect-gcp(given there are many pre-built tasks and block methods that usesync_compatibleor depend on the sneaky async-in-sync compatibility that we often used in 2.x)it may be worth coming back to this and defining explicit methods for each thing (
{method}_async) in the future, but continuing to usesync_compatiblehere felt like the most prudent option for now