Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip on cancellation hooks if runner cant load flow #13660

Merged
merged 2 commits into from
May 30, 2024

Conversation

zangell44
Copy link
Collaborator

This PR adds exception handling to skip cancellation hooks if a Runner can't load the flow code. A similar fix has already been made for workers https://github.com/PrefectHQ/prefect/pull/12001/files.

Closes #12389.

Once merged I'll open a PR to 2.x.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in docs/mint.json navigation.

@zangell44 zangell44 added the fix A fix for a bug in an existing feature label May 30, 2024
@zangell44 zangell44 requested a review from a team as a code owner May 30, 2024 14:44
Copy link
Contributor

@serinamarie serinamarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zangell44 zangell44 merged commit 614318b into main May 30, 2024
22 of 26 checks passed
@zangell44 zangell44 deleted the fix-cancelling-runs-without-deployment-on-runner branch May 30, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancellation of flow runs that correspond to deleted deployments
2 participants