Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paused states subclass Scheduled #1375

Merged
merged 5 commits into from
Aug 17, 2019
Merged

Paused states subclass Scheduled #1375

merged 5 commits into from
Aug 17, 2019

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Aug 17, 2019

Paused states can have fixed expirations

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Closes #1342 and allows pauses to have pre-defined expirations.

Paused states can have fixed expirations
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two requests:

  • I believe you'll need to update the Paused state serialization schema as well.
  • could you add an optional start_time kwarg to the pause_task utility located in utilities/tasks.py?

Otherwise, it's awesome how simple this is!

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #1375 into master will decrease coverage by 0.01%.
The diff coverage is 94.44%.

@jlowin jlowin merged commit beecbdd into master Aug 17, 2019
@jlowin jlowin deleted the paused-scheduled branch August 17, 2019 21:07
abrookins pushed a commit that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Paused should subclass Scheduled
2 participants