Rename RedisFilesystem to RedisStorageContainer to match naming semantics of other filesystem classes
#13771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emantics of other filesystem classes
desertaxle
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
@desertaxle I think this naming brings it inline with the others, thoughts?
I think what I want is a block that does normal Redis stuff without our Filesystem methods and a block that is specific to our Filesystem interface that composed the normal Redis stuff block. I also think that we should build out this library and get the names sorted out afterwards because I keep second-guessing myself.
TL;DR: I'm good with this or RedisFilesystem, but we might want to revisit once we've built out more functionality.
|
Agreed, this block alone is pretty sad for an integration, definitely should add more functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@desertaxle I think this naming brings it inline with the others, thoughts?
Related to #12249