Refactor task run engine #13793
Merged
Refactor task run engine #13793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the engine to create utility methods that allow very lightweight "caller" functions (e.g.
run_task_syncandrun_task_async) which invoke an engine to govern a given task. A major motivation of this refactor is to make it easy to extend the engine to other types of tasks (generators, contexts, and more) without needing to rewrite all of the runtime logic.In the current implementation, you have to know exactly which engine methods to invoke and when in order to run a task - totalling 50 LOC for each of
run_task_syncandrun_task_async. While this refactor moves code rather than removes code, it does result in much thinner callers that are easier to extend to novel task types or situations.