Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit get-started/install page #13822

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Edit get-started/install page #13822

merged 6 commits into from
Jun 6, 2024

Conversation

LarryUllman
Copy link
Collaborator

@LarryUllman LarryUllman commented Jun 6, 2024

This cleans up the get-started/install page

  • change title to "Install"
  • page doesn't discuss configuration so I removed that text
  • DB content goes on the self-hosted page (makes this page simpler and encourages "just use Cloud")
  • remove esoteric content
  • make the TOC cleaner and better targeted
  • point to quickstart after this instead of the tutorial

I also removed the instructions for how to install SQLite entirely because:

  • As mentioned in the text, SQLite is already commonly installed
  • That information isn't specific to Prefect
  • That information is already--and better--found elsewhere online

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in mint.json for files that are removed or renamed.

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes to simplify! Minor nits.

docs/3.0rc/cloud/self-host.mdx Outdated Show resolved Hide resolved
docs/3.0rc/cloud/self-host.mdx Outdated Show resolved Hide resolved
docs/3.0rc/cloud/self-host.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@discdiver discdiver self-requested a review June 6, 2024 17:49
@discdiver discdiver merged commit 92b34cd into main Jun 6, 2024
3 checks passed
@discdiver discdiver deleted the larry-docs-install branch June 6, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants