-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a url_for
utility for generating URLs for Prefect objects
#13885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrookins
changed the title
Use the new url_for utility in a few places
Add a Jun 7, 2024
url_for
utility for generating URLs of Prefect objects
abrookins
commented
Jun 7, 2024
abrookins
changed the title
Add a
Add a Jun 7, 2024
url_for
utility for generating URLs of Prefect objectsurl_for
utility for generating URLs for Prefect objects
zzstoatzz
reviewed
Jun 8, 2024
Co-authored-by: nate nowack <thrast36@gmail.com>
Co-authored-by: nate nowack <thrast36@gmail.com>
I'm ok with where this landed, but I'll probably want to go back someday and add all the different variations of each schema, since there are a lot of different versions of each one (server vs. client runs, server vs. core event and automations schemas, etc.). |
chrisguidry
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautifully done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
url_for
utility function that generates a URL for any Prefect API object. This gives us a consistent place to generate URLs (something we do in various places) and also gives users a way to generate a UI URL or API URL for API objects, such asFlowRun
s,TaskRun
s andPrefectFuture
objects representing task runs.Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
mint.json
for files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.json
navigation.