Require a PREFECT_API_URL to start a worker
#13942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there's no `PREFECT_API_URL` set, calls to `get_client` will start the ephemeral server transparently for the user. This works amazingly well for running single flows and tasks for demos and testing. In the default configuration, you can share a SQLite database across several Prefect processes, like a server and a worker, and things will generally appear to work. However, when we start to get into more advanced infrastructure like `Worker` and `TaskWorker`, it doesn't make sense to run these ephemerally without a Prefect server. Event-driven workflows and background task scheduling require a running server, and we should be explicit about that fact to avoid the possibility for confusion (like events not being emitted, or automations not running as expected). Fixes #13876
jakekaplan
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's no
PREFECT_API_URLset, calls toget_clientwill start theephemeral server transparently for the user. This works amazingly well for
running single flows and tasks for demos and testing. In the default
configuration, you can share a SQLite database across several Prefect processes,
like a server and a worker, and things will generally appear to work.
However, when we start to get into more advanced infrastructure like
Workerand
TaskWorker, it doesn't make sense to run these ephemerally without aPrefect server. Event-driven workflows and background task scheduling require
a running server, and we should be explicit about that fact to avoid the
possibility for confusion (like events not being emitted, or automations not
running as expected).
Fixes #13876