Removed references to SequentialTaskRunner #13996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billpalombi
approved these changes
Jun 13, 2024
zzstoatzz
reviewed
Jun 13, 2024
Comment on lines
+9
to
+10
| Task runners are not required for task execution. Calling a task function directly without a task runner executes the | ||
| function sequentially by default. Execution of a task function blocks execution of its flow until the task completes. |
There was a problem hiding this comment.
Suggested change
| Task runners are not required for task execution. Calling a task function directly without a task runner executes the | |
| function sequentially by default. Execution of a task function blocks execution of its flow until the task completes. | |
| Task runners are not required for task execution. Directly calling a function decorated with `@task` executes it like a normal python function, that is, it blocks execution of the parent flow run until the task completes. |
zzstoatzz
reviewed
Jun 13, 2024
| @flow(task_runner=DaskTaskRunner()) | ||
| def dask_subflow(): | ||
| hello_dask.submit() | ||
|
|
||
| @flow(task_runner=ConcurrentTaskRunner()) |
There was a problem hiding this comment.
wouldn't be needed since each subflow specifies its own task_runner already
Suggested change
| @flow(task_runner=ConcurrentTaskRunner()) | |
| @flow |
zzstoatzz
reviewed
Jun 13, 2024
|
|
||
| <Note> |
There was a problem hiding this comment.
perhaps we could keep an admonition like "SequentialTaskRunner is longer necessary, just call your task" or link to task concept page since it seems likely that people will have used it for one reason or another and come here looking for it after installing 3.x / breaking imports
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this brought up by someone who found that their usage of SequentialTaskRunner was no longer working. I've changed the explanation and examples of task runners to explain how tasks are sequential by default, and concurrent by default, when using .submit().
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
mint.jsonfor files that are removed or renamed.For new functions or classes in the Python SDK:
docs/mint.jsonnavigation.