Closes another race condition in task waiting #14124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a very narrow gap here, but it's possible nonetheless, where an event could sneak through in the time between checking for a previously completed task run and when we start waiting for the event to arrive on the websocket. This closes the gap so that we make one more check just before we start waiting, after having established the `asyncio.Event` for completion. Part of #14098
zzstoatzz
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a very narrow gap here, but it's possible nonetheless, where an event
could sneak through in the time between checking for a previously completed
task run and when we start waiting for the event to arrive on the websocket.
This closes the gap so that we make one more check just before we start waiting,
after having established the
asyncio.Eventfor completion.Part of #14098