Disables server-side PENDING task rescheduling by default
#14128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During my load testing, it became clear that this feature won't work as-is on such a short timescale. Because tasks remain `PENDING` until all of their dependencies are resolved, it's possible that a long period of time may elapse before those `PENDING` tasks can actually move on to `RUNNING`, and in a system with deep dependencies, this can put the task workers in a position where they can't keep up and are constantly getting redelivered tasks. Rather than defaulting this to on, we should let the user opt-in to the behavior for now, based on their workload.
zzstoatzz
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During my load testing, it became clear that this feature won't work as-is on
such a short timescale. Because tasks remain
PENDINGuntil all of theirdependencies are resolved, it's possible that a long period of time may elapse
before those
PENDINGtasks can actually move on toRUNNING, and in a systemwith deep dependencies, this can put the task workers in a position where they
can't keep up and are constantly getting redelivered tasks.
Rather than defaulting this to on, we should let the user opt-in to the behavior
for now, based on their workload.