Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes passing PrefectFutures to flows #14152

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jun 19, 2024

This PR fixes a bug where a flow would fail if a PrefectFuture was passed. The fix was to run parameter validation after all upstream dependencies were resolved.

Closes #14036

Example

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Jun 19, 2024
@desertaxle desertaxle requested a review from a team as a code owner June 19, 2024 16:54
@desertaxle desertaxle merged commit e26dcdb into main Jun 19, 2024
27 checks passed
@desertaxle desertaxle deleted the fix-futures-passed-to-flows branch June 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subflows unable to resolve PrefectFutures when passed as parameters
2 participants