Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to defer result persistence #14155

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Add ability to defer result persistence #14155

merged 7 commits into from
Jun 19, 2024

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jun 19, 2024

This PR adds the ability to defer result persistence; in a follow up PR this will allow us to persist only on commit without changing any observable behavior.

@cicdw cicdw requested a review from a team as a code owner June 19, 2024 18:58
@cicdw cicdw requested a review from desertaxle June 19, 2024 18:58
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing that might be useful is a test to ensure that calling write multiple times only persists data once.

@cicdw
Copy link
Member Author

cicdw commented Jun 19, 2024

@desertaxle added 🫡

@cicdw cicdw merged commit a93b4f8 into main Jun 19, 2024
26 checks passed
@cicdw cicdw deleted the result-defer-persistence branch June 19, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants