Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some updates to the contributing sections of the docs #14161

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Make some updates to the contributing sections of the docs #14161

merged 3 commits into from
Jun 19, 2024

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jun 19, 2024

This PR:

  • touches up the Contributing section of our docs
  • changes the default to light mode (I don't think a documentation site should ever default to dark mode)

@cicdw cicdw requested a review from a team as a code owner June 19, 2024 21:13
billpalombi
billpalombi approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@billpalombi billpalombi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of "yes, and" recommendations. I'm not wedded to the specific language I proposed.

This change may break some links, but we can handle that separately.

docs/contribute/dev-contribute.mdx Outdated Show resolved Hide resolved
docs/contribute/dev-contribute.mdx Show resolved Hide resolved
cicdw and others added 2 commits June 19, 2024 14:54
@cicdw @billpalombi
Update docs/contribute/dev-contribute.mdx
af618af 
Co-authored-by: Bill Palombi <bill@prefect.io>
@cicdw
Incorporate feedback
20f1381
@cicdw cicdw merged commit a6b5dae into main Jun 19, 2024
4 checks passed
@cicdw cicdw deleted the my-first-docs-pr branch June 19, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billpalombi billpalombi billpalombi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicdw @billpalombi