Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence runtime errors for ephemeral shutdown #14163

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Silence runtime errors for ephemeral shutdown #14163

merged 2 commits into from
Jun 20, 2024

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Jun 19, 2024

When using the ephemeral API, one will occasionally see a frightening traceback because events are being received after interpreter shutdown has begun, which is an error specific to 3.12.2. This was addressed for logs in #13831, and this PR adds the same behavior (plus a debug log) for events.

@jlowin jlowin requested review from zangell44 and a team as code owners June 19, 2024 21:44
@jlowin jlowin merged commit f8cb3a6 into main Jun 20, 2024
26 checks passed
@jlowin jlowin deleted the avoid-runtimeerror branch June 20, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants