Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deadlocks with default ThreadPoolTaskRunner settings #14201

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jun 20, 2024

This PR fixes deadlocks with the default ThreadPoolTaskRunner by setting the max_workers setting arbitrarily high by default. In rare occasions, this will lead to thread exhaustion, but the default worker count in the ThreadPoolExecutor has proven to be too low in cases with nested dependent runs.

Closes #14194

Example

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@desertaxle desertaxle requested a review from a team as a code owner June 20, 2024 21:30
@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Jun 20, 2024
@desertaxle desertaxle merged commit ed41da9 into main Jun 20, 2024
28 checks passed
@desertaxle desertaxle deleted the limitless-thread-pool-task-runner branch June 20, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hangs with ThreadPoolTaskRunner
2 participants