Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility: Phase 1 #1456

Merged
merged 12 commits into from
Sep 6, 2019
Merged

Windows compatibility: Phase 1 #1456

merged 12 commits into from
Sep 6, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Sep 6, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR begins our path (😉) towards full Windows compatibility. Much of the changes here are low-hanging fruit caused by casual path manipulation. The only painful thing is that Windows doesn't like open temporary files being written to and then read from by a separate reader.

Why is this PR important?

Prefect Core has been semi-stable for Windows users for a while, but recent onboards to Cloud have shown us that our Cloud + Windows compatibility isn't very robust. We hope to change that for the next release. As of this PR, there are about 30 failing tests remaining, many of which only require changes to the tests, not the code itself.

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1456 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@cicdw cicdw merged commit d63501f into master Sep 6, 2019
@cicdw cicdw deleted the windows-phase-1 branch September 6, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants