Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed rename of CloudEnvironment #1458

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Fix missed rename of CloudEnvironment #1458

merged 1 commit into from
Sep 6, 2019

Conversation

bnaul
Copy link

@bnaul bnaul commented Sep 6, 2019 •
edited
Loading 

(model) ➜  model git:(chicago) ✗ kl -f prefect-dask-job-1e0579da-5fde-4c6a-adfe-ce618147bcff-c2qgb
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: cannot import name 'CloudEnvironment' from 'prefect.environments' (/usr/local/lib/python3.7/site-packages/prefect/environments/__init__.py)

@joshmeek
Copy link

joshmeek commented Sep 6, 2019

Awesome! Could you also add this change to the CHANGELOG since this seems to be fixing a previously unknown bug?

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1458 into master will not change coverage.
The diff coverage is n/a.

@joshmeek joshmeek merged commit e36fd86 into PrefectHQ:master Sep 6, 2019
@bnaul bnaul deleted the patch-3 branch September 6, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeek joshmeek joshmeek approved these changes

@cicdw cicdw Awaiting requested review from cicdw

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnaul @joshmeek