Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal 3 warnings #14675

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Removal 3 warnings #14675

merged 9 commits into from
Jul 19, 2024

Conversation

WillRaphaelson
Copy link
Contributor

@WillRaphaelson WillRaphaelson commented Jul 19, 2024 •
edited
Loading

This PR adds deprecation warnings for anything we know is moving or being removed in Prefect 3.0.0, if one did not already exist.

Closes #14676

Checklist

  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@WillRaphaelson WillRaphaelson added the enhancement An improvement of an existing feature label Jul 19, 2024
@WillRaphaelson WillRaphaelson changed the base branch from main to 2.x July 19, 2024 16:20
@WillRaphaelson WillRaphaelson mentioned this pull request Jul 19, 2024
Closed
3 tasks
@WillRaphaelson WillRaphaelson marked this pull request as ready for review July 19, 2024 18:45
chrisguidry
chrisguidry approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding!

@WillRaphaelson WillRaphaelson merged commit 8429480 into 2.x Jul 19, 2024
37 of 60 checks passed
@WillRaphaelson WillRaphaelson deleted the removal-3-warnings branch July 19, 2024 19:07
@desertaxle desertaxle mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisguidry chrisguidry chrisguidry approved these changes

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillRaphaelson @chrisguidry