Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise on exception no longer raises for prefect signals #1562

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Sep 27, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

The raise_on_exception no longer re-raises Prefect Signals during execution.

Why is this PR important?

This PR helps target the re-raises to "unexpected" errors, for a better debugging experience when using things like switch control flow tasks.

@cicdw cicdw merged commit 1667c15 into master Sep 27, 2019
@cicdw cicdw deleted the raise-on-exc-finesse branch September 27, 2019 21:25
zanieb pushed a commit that referenced this pull request Apr 13, 2022
Avoid latest sqlalchemy release which breaks inserts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants