Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing: Environment Callbacks #1610

Merged
merged 12 commits into from
Oct 9, 2019
Merged

Introducing: Environment Callbacks #1610

merged 12 commits into from
Oct 9, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 9, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR is an implementation of PIN-12 for environment on_start and on_exit callbacks. It also adds a short concept doc for Environments and Storage.
Closes #1495
Closes #1574
Closes #1581

Why is this PR important?

Environment related callbacks are important tools for performing work outside of environment infrastructure and flow operations.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #1610 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool / so simple. A few comments / questions on first pass

docs/cloud/concepts/execution.md Show resolved Hide resolved
src/prefect/environments/execution/dask/k8s.py Outdated Show resolved Hide resolved
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I'm excited to see how this gets used.

@joshmeek joshmeek merged commit 2f3c034 into master Oct 9, 2019
@joshmeek joshmeek deleted the environment_callbacks branch October 9, 2019 20:56
zanieb pushed a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants