Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance EmailTask to accept smtp server settings and email_from #1619

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

shrmnk
Copy link

@shrmnk shrmnk commented Oct 16, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Replaces #1616 to provide a more customisable EmailTask that defaults to Gmail's servers so that it does not become a breaking change.

Why is this PR important?

EmailTask sounds like a generic name but it was previously hardcoded to Gmail servers.

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @shrmnk! 🎉 🎉

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent enhancement! Thanks for the contribution @shrmnk ! The failing tests will be fixed when we update your branch with #1621

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #1619 into master will decrease coverage by 0.02%.
The diff coverage is 76.92%.

@cicdw cicdw merged commit fbae334 into PrefectHQ:master Oct 16, 2019
zanieb pushed a commit that referenced this pull request Apr 13, 2022
Make scheduler robust to exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants