Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds an ask for help button (with link to website support page) to the docs #1637

Merged
merged 3 commits into from
Oct 17, 2019
Merged

adds an ask for help button (with link to website support page) to the docs #1637

merged 3 commits into from
Oct 17, 2019

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Oct 17, 2019 •
edited
Loading

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

  • Adds an "Ask for help" button on the welcome page which takes (if clicked) takes a user to the prefect.io/support page

Why is this PR important?

  • Helps users find the support page

@zhen0 zhen0 marked this pull request as ready for review October 17, 2019 21:45
@zhen0
Copy link
Member Author

zhen0 commented Oct 17, 2019

Linear issue: https://linear.app/issue/CLOUD-248

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #1637 into master will not change coverage.
The diff coverage is n/a.

cicdw
cicdw approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks @zhen0 !

@cicdw cicdw merged commit 9391f52 into PrefectHQ:master Oct 17, 2019
zanieb pushed a commit that referenced this pull request Apr 13, 2022
@pleek91
Merge pull request #1637 from PrefectHQ/fix-flow-run-tag-filter
5d827f2 
UI: bugfix flow run tag filters in orion-design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@jlowin jlowin Awaiting requested review from jlowin

@joshmeek joshmeek Awaiting requested review from joshmeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhen0 @cicdw