Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SnowflakeQuery task #1663

Merged
merged 13 commits into from
Oct 27, 2019
Merged

Conversation

mhmcdonald
Copy link

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

It was reported on the prefect-core slack channel that the SnowflakeQuery task is not working, because it uses a query parameter in the snowflake-connector that does not exist. As the task code is written, it is expecting a named arg query. Instead, the snowflake-connector uses a positional argument that it calls command, seen here: https://github.com/snowflakedb/snowflake-connector-python/blob/54d4fa33306e24a39cbe6596bc8927990d8ef153/cursor.py#L424

This PR is a simple change to the call of cursor.execute() in the SnowflakeQuery run method. I've tested this change in my project.

Why is this PR important?

As it exists, the SnowflakeQuery task does not work.

@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #1663 into master will not change coverage.
The diff coverage is 100%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you @mhmcdonald !

@cicdw cicdw merged commit f228643 into PrefectHQ:master Oct 27, 2019
zanieb pushed a commit that referenced this pull request May 12, 2022
…-ui/prefecthq/miter-design-0.1.34

Bump @prefecthq/miter-design from 0.1.33 to 0.1.34 in /orion-ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants