Fix for SnowflakeQuery task #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 8, 2019 16:01
…x_snowflake_task
cicdw
approved these changes
Oct 27, 2019
zanieb
pushed a commit
that referenced
this pull request
May 12, 2022
…-ui/prefecthq/miter-design-0.1.34 Bump @prefecthq/miter-design from 0.1.33 to 0.1.34 in /orion-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md(if appropriate)docs/outline.tomlfor API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
It was reported on the prefect-core slack channel that the SnowflakeQuery task is not working, because it uses a
queryparameter in the snowflake-connector that does not exist. As the task code is written, it is expecting a named argquery. Instead, the snowflake-connector uses a positional argument that it callscommand, seen here: https://github.com/snowflakedb/snowflake-connector-python/blob/54d4fa33306e24a39cbe6596bc8927990d8ef153/cursor.py#L424This PR is a simple change to the call of cursor.execute() in the SnowflakeQuery run method. I've tested this change in my project.
Why is this PR important?
As it exists, the SnowflakeQuery task does not work.