Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default 30s timeout to client requests #1672

Merged
merged 2 commits into from
Oct 29, 2019
Merged

Add default 30s timeout to client requests #1672

merged 2 commits into from
Oct 29, 2019

Conversation

joshmeek
Copy link

@joshmeek joshmeek commented Oct 28, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Updates the Client requests to have a default timeout of 30 seconds

Why is this PR important?

Without providing a timeout it has the potential to hang indefinitely

@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #1672 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@joshmeek joshmeek merged commit f2e4b04 into master Oct 29, 2019
@joshmeek joshmeek deleted the request_timeout branch October 29, 2019 13:38
zanieb pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants