Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for directly-passing secrets to task library tasks #1673

Merged
merged 5 commits into from
Oct 29, 2019

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Oct 29, 2019

Closes #1669 by adding support for passing values directly to various task library tasks.

This PR attempts to maintain all prior behavior, just raising a warning if the secret name is passed instead of a value.

In addition, it's a little noisy because it coincides with the release of a new version of black

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1673 into master will increase coverage by 0.03%.
The diff coverage is 97.67%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only concern I have is that this introduces a large number of breaking changes; I know you did it so that you can detect when to raise the deprecation warning, but we should at least call this out in the Changelog.

tests/tasks/twitter/test_twitter.py Show resolved Hide resolved
@cicdw cicdw merged commit a66c096 into master Oct 29, 2019
@cicdw cicdw deleted the credentials branch October 29, 2019 19:05
zanieb pushed a commit that referenced this pull request May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor secret-dependent tasks to use new secrets API
2 participants