Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow save / load #1685

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Flow save / load #1685

merged 5 commits into from
Oct 30, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Oct 30, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR introduces a save / load interface to Flows for a smoother deployment experience.

Why is this PR important?

Some users were annoyed with cloudpickle's behavior if you create a Flow in a file called "my_flow.py" and then imported that flow inside "my_deploy.py" like from my_flow import flow, deploy health checks would fail. This is because cloudpickle sees your flow's logic as living inside a module called "my_flow".

Using the new save / load interface allows users to save their flow at build time, so that cloudpickle correctly manages the imports.

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #1685 into master will increase coverage by <.01%.
The diff coverage is 100%.

@cicdw cicdw merged commit ec1a6f8 into master Oct 30, 2019
@cicdw cicdw deleted the save-load branch October 30, 2019 01:16
@aroder
Copy link

aroder commented Oct 30, 2019

Yeah! This is helpful. I find that creating a "build" folder at the top level of my project and excluding it from source control is a convenient place to put the pickled flow.

zanieb pushed a commit that referenced this pull request May 12, 2022
…-ui/d3-7.4.4

Bump d3 from 7.4.3 to 7.4.4 in /orion-ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants