Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Flow save / load interface #1695

Merged
merged 8 commits into from
Nov 2, 2019
Merged

Improvements to Flow save / load interface #1695

merged 8 commits into from
Nov 2, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Nov 2, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR improves upon the save / load interface for flows by:

  • introducing a sensible default save location which just happens to coincide with the save location inside Docker storage objects ;)
  • introducing a sensible inference pattern on load so that absolute paths, flow names, and slug-ified flow names are all acceptable inputs
  • uses the save / load interface inside Local storage

@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #1695 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@cicdw cicdw merged commit 8dcf82b into master Nov 2, 2019
@cicdw cicdw deleted the save-dir branch November 2, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants