Raise informative error whenever context is pickled #1711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR raises an informative error whenever
context
is pickled. Closes #1710Why is this PR important?
Users are tempted to use context like:
and submit such tasks to dask. This is problematic, because if we freeze context (which is what this import pattern effectively does), we lose all the dynamic information that is placed into context by the various runners.
Consequently, users should always access context as an attribute of the top-level module so that dynamically added keys will be available.
This PR raises an informative error for how to access context in the event that it is pickled.