Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful agent shutdowns #1731

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Graceful agent shutdowns #1731

merged 4 commits into from
Nov 12, 2019

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Nov 12, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

For most local agents, especially during testing, users tend to use CTRL+C or some other keyboard interrupt signal to kill a running agent. This PR adds a graceful shutdown mode for all agents when a keyboard interrupt is passed. It prints agent is shutting down and waits for the final loop to process.

Why is this PR important?

Better user experience.

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1731 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

@cicdw cicdw merged commit d5ded59 into master Nov 12, 2019
@cicdw cicdw deleted the graceful-agents branch November 12, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants