[WIP] Remove over-engineered aspect of prefect context #703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)What does this PR change?
This PR removes an over-engineered aspect of Prefect context - they are no longer thread local objects.
Why is this PR important?
Two things were happening to me:
with prefect.context(secrets=...): flow.run()
anddask
would attempt to pickle the context object and fail__setstate__
and__getstate__
methods, and despite this some of my updated keys in context were not being found within the task runnersRemoving
threading.local
appeared to fix both of these problems in a simple way, and I don't think it's necessary forcontext
to be threadsafe (please correct me if I'm wrong). Our use of context is always that downstream function calls retrieve information from context without updating context.