Add setting to exclude traversal of Pydantic models in parameters #8763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
commented
Mar 9, 2023
| @@ -29,6 +29,8 @@ | |||
|
|
|||
| import pydantic | |||
|
|
|||
| from prefect.settings import PREFECT_PARAMETERS_TRAVERSE_PYDANTIC_MODELS | |||
There was a problem hiding this comment.
This seems like it ought to live in the engine and visit_collection should take a set of types to exclude traversal of. However, it's simpler to put it here and I'm not sure how much the purity matters.
zanieb
commented
Mar 9, 2023
| @@ -594,6 +594,16 @@ def default_cloud_ui_url(settings, value): | |||
| flow and task results will be persisted unless they opt out. | |||
| """ | |||
|
|
|||
| PREFECT_PARAMETERS_TRAVERSE_PYDANTIC_MODELS = Setting( | |||
There was a problem hiding this comment.
I'm not sure I love this name.
4 tasks
|
Deferring this in favor of explicitly using quote for now. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns raised in #8542 by allowing Pydantic model traversal to be disabled so they are not copied during visits. We could introduce a setting like this for dataclasses as well.