Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change NGCF Batch Size Param #532

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Change NGCF Batch Size Param #532

merged 3 commits into from
Oct 18, 2023

Conversation

darrylong
Copy link
Member

Description

  • Changed NGCF Batch Size param: 'train_batch_size' --> 'batch_size'
  • Removed 'test_batch_size' as it is no longer used.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@darrylong darrylong requested a review from tqtg October 17, 2023 10:14
@darrylong darrylong self-assigned this Oct 17, 2023
@darrylong darrylong merged commit 0955645 into PreferredAI:master Oct 18, 2023
12 checks passed
@darrylong darrylong deleted the hotfix-ngcf-batchsize branch October 18, 2023 02:58
darrylong added a commit to darrylong/cornac that referenced this pull request Oct 23, 2023
@darrylong
Change NGCF Batch Size Param (PreferredAI#532)
24ea5be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqtg tqtg tqtg approved these changes

Assignees

@darrylong darrylong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrylong @tqtg