Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more build platforms in GitHub Actions #612

Merged
merged 43 commits into from
Apr 4, 2024

Conversation

tqtg
Copy link
Member

@tqtg tqtg commented Apr 2, 2024

Description

Currently we don't have actions to test and build binaries for MacOS arm64 platform (M chips). That's the main motivation for this update.

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

@tqtg tqtg added the maintenance Changes relating to build process, tools and libraries such as docs generation. label Apr 2, 2024
@tqtg
Copy link
Member Author

tqtg commented Apr 3, 2024

@darrylong finally it works

@tqtg
Copy link
Member Author

tqtg commented Apr 4, 2024

@darrylong are we good with all the changes?

@darrylong
Copy link
Member

LGTM!

@darrylong darrylong assigned tqtg and unassigned darrylong Apr 4, 2024
@darrylong darrylong self-requested a review April 4, 2024 16:08
@tqtg tqtg merged commit cbdc8f2 into PreferredAI:master Apr 4, 2024
24 checks passed
@tqtg tqtg deleted the github-actions-build-matrix branch April 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes relating to build process, tools and libraries such as docs generation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants