Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated AsyncFetcher to expose more HttpAsyncClientBuilder options and standardise Builder #1

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Updated AsyncFetcher to expose more HttpAsyncClientBuilder options and standardise Builder #1

merged 4 commits into from
Jan 7, 2019

Conversation

lwj5
Copy link
Member

@lwj5 lwj5 commented Jan 7, 2019

Added options in AsyncFetcher.Builder:

  • maxRouteConnections
  • maxConnections
  • sslContext
  • redirectStrategy
  • disableCookieManagement

Modified

  • compressed -> disableCompression

@lwj5 lwj5 added the enhancement New feature or request label Jan 7, 2019
@lwj5 lwj5 self-assigned this Jan 7, 2019
@lwj5 lwj5 requested a review from sitfoxfly January 7, 2019 07:10
@coveralls
Copy link

coveralls commented Jan 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 82

  • 12 of 24 (50.0%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.3%) to 73.632%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/ai/preferred/venom/fetcher/AsyncFetcher.java 9 21 42.86%
Files with Coverage Reduction New Missed Lines %
src/main/java/ai/preferred/venom/Crawler.java 1 73.39%
src/main/java/ai/preferred/venom/fetcher/AsyncFetcher.java 3 65.19%
Totals Coverage Status
Change from base Build 78: 1.3%
Covered Lines: 740
Relevant Lines: 1005
💛 - Coveralls

sitfoxfly
sitfoxfly requested changes Jan 7, 2019
View reviewed changes
Copy link
Member

@sitfoxfly sitfoxfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it 4.1.0-SNAPSHOT, so that we can rename all the builder methods. That would be consistent with the renamed "compressed".

@lwj5 lwj5 changed the title Updated AsyncFetcher to expose more HttpAsyncClientBuilder options Updated AsyncFetcher to expose more HttpAsyncClientBuilder options and standardise Builder Jan 7, 2019
@sitfoxfly sitfoxfly merged commit 470924a into PreferredAI:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitfoxfly sitfoxfly sitfoxfly approved these changes

Assignees

@lwj5 lwj5

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwj5 @coveralls @sitfoxfly