Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning #126

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Update versioning #126

merged 6 commits into from
Jul 6, 2023

Conversation

antoinemeyer5
Copy link
Collaborator

@antoinemeyer5 antoinemeyer5 commented Jun 22, 2023

Change content of version.txt.

Change reading version way in conf.py

Create cmake folder.

Addition of a specific function in the cmake folder.

Use this function in the CMakeLists.txt file to obtain the PressioDemoapps version written in the version.txt file.


Change in setup.cfg. It adds a handwritten version because file version.txt can no longer be read directly.

@antoinemeyer5 antoinemeyer5 changed the title Update versioning in CMakeLists.txt Update versioning Jun 22, 2023
@fnrizzi fnrizzi changed the base branch from main to develop June 29, 2023 10:32
@fnrizzi
Copy link
Member

fnrizzi commented Jul 5, 2023

adds a handwritten version because file version.txt can no longer be read directly.

why? are you saying that if we were to write inside version.txt just 0.14.0 it would work?

@antoinemeyer5
Copy link
Collaborator Author

antoinemeyer5 commented Jul 6, 2023

adds a handwritten version because file version.txt can no longer be read directly.

why? are you saying that if we were to write inside version.txt just 0.14.0 it would work?

yes

because now version.txt is:

VERSION_MAJOR 0
VERSION_MINOR 14
VERSION_PATCH 0

so you have to do things before getting 0.14.0 so setup.cfgcannot take this version.txt just like that anymore


It is not the best solution because in this repo, if you want to change versions, you have to do it in 2 differents places...

@fnrizzi
Copy link
Member

fnrizzi commented Jul 6, 2023

please keep version.txt as just:

0.14.0

i rather do this

@antoinemeyer5 antoinemeyer5 marked this pull request as draft July 6, 2023 08:36
@antoinemeyer5 antoinemeyer5 self-assigned this Jul 6, 2023
@antoinemeyer5
Copy link
Collaborator Author

please keep version.txt as just:

0.14.0

i rather do this

Ok well it's almost like doing nothing

@antoinemeyer5 antoinemeyer5 marked this pull request as ready for review July 6, 2023 09:09
@fnrizzi
Copy link
Member

fnrizzi commented Jul 6, 2023

Ok well it's almost like doing nothing
what do you mean?

@fnrizzi fnrizzi merged commit d23bbff into Pressio:develop Jul 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants