-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#70: pull in pressiolinalg pypi package #126
#70: pull in pressiolinalg pypi package #126
Conversation
cd4338c
to
d80ecc5
Compare
@fnrizzi @eparish1 This PR is ready for review. I added a unit test for the new package, but it will likey become unnecessary once we begin to incorporate the package into source code (since existing tests would then catch any problems).
That being said, should I keep the test in or drop it from the PR? |
the linalg library should have its own testsuite. since that is the case, we should remove tests related to it from this repo. |
@cwschilly can you also please replace in romtools all functions to call the linalg library functions? |
@cwschilly @fnrizzi I agree about Francesco's comments on the tests. But this looks good. I'm fine to replace the calls to linalg in this PR or another one, whatever is easiest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwschilly This is wonderful, thanks for doing all of this. This looks great by me. @fnrizzi good by you?
@cwschilly @fnrizzi you both are tracking where things are at here better than me. Could one of you do the merge when things are ready? Thanks! |
60ca530
to
eb4ea3b
Compare
Fixes #70
Related to pressio-linalg PR 8
Changes
pressio-linalg
is now a required dependency.Usage
Note that there is no hyphen for the import.
Current API
These are all subject to change and will be documented in this issue.