-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge branch (#3) #15481
Closed
Closed
merge branch (#3) #15481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding autoUpgrade module Page * Adding selectors to homePage * Adding test UpgradeShop * Fix grids data when in single shop context * Fix productWOImages grid show default shop in allShopContext * Adds missing `where` statement in products sql query * Fix lint * Integrate perfet-scrollbar for new-theme * Integrate perfect scroll on default them * Build assets * Remove another faulty e2e test from Travis * Adding env argument and use it in Upgrade test * Adding expect in autoUpgrade Page * Separate services tests and Prestashop * New docker file and docker compose for version 1.7.5.2 * Delete docker-compose * fix issue #9663 * Disable e2e Travis builds for now * Get image from prestashop-git * Change command to run docker_run_git.sh (composer install) * Changing name of dockerfile in docker-compose * Adding Env variable PS_VERSION * Checkout to specific version if env var is not empty * change file to a dockerfile * Fix translations interface - Module translations are no longer attached to the currently selected theme - Email translations no longer are attached to an invalid theme called "subject" * Build assets * Deleted unused private method * Rename file ps-git to Dockerfile-from-git * Rename PS_VERSION to PS_VERSION_TO_INSTALL * Add PS_VERSION env variable used in upgrade test * Remove Docker from README add add DOCKER.md file * Add upgrade test to README * Fix bug when getting currency name containing localiazed names * Add method to CurrencyDataProviderInterface to allow fetching all available currencies * Fix command in DOCKER.md * Fix QA comments * Apply CS fixer * Builds assets * feat: remove clear email * make email display optional * Add space betwenn lines in Docker.md * Rename methods/parameters and add optional parameter instead of new method * Fix the product selector in the FO * Add the class name in the selector * Increase timeout to wait Prestashop to 720s * updated * Add hook to display the address extra added fields This hook will helpful to display the content added as an extra field in the address block. * fix issue #9663 * updated * Fix filtering by customer * Update invalid characters in Customer Creation & Update error messages and tips * Move code for cleaning character in its own class and remove methods in Tools Adapter * Fix wording * Use ContainerFinder * Added a debug_print_backtrace for Travis * Sort smoke tests by adding number to the names * Modified the method for calling directly the class if no container is available * Removed the debug_print_backtrace and caught the exception in ContainerFinder * // Changelog 1.7.6.1 * Change .sr-only hidden span to aria-label #15083 https://www.w3.org/TR/WCAG20-TECHS/ARIA14.html * Fix one column row without colspan All <tr> have 2 <td> except the last one. * Use a different way to sort order products * Remove useless code * Remove foreach and update string indentation * Move it into two requests because on some engine update order on multiple tables is not working * Add comments to explain why there are two requests * Remove outdated comment * Checked the case where there are no point * Renaming data names * Fixed the unit test and added some case * Modified a comment * Fixed Coding Style errors * Adds behat for creating cms page * behat for create CmsPage comand * Adds behat for delete cms page * Adds some create/edit with invalid data cases * Refactor cms tests for less code duplication * Optimize to use array instead of TableNode when getting creation data * Clarifies cms to CMS * Tiny code cleaning * Get Configuration from container instead of static legacy object * Removes some cases that belongs to units, Adds bulk status toggle behats * Adds bulk enable and bulk delete behats * Removes unnecessary spacing * Removes deleting by id, uses reference instead. Some optimizations, start using PrimitiveUtils * Add storage clearing after cmsPageRemoval * Fix cmsCategory check of null * Sanity tests orderBO * Classic Theme : Plugin EmailSubscription : override the template for column * Fix the class in SCSS file * Fix the class in SCSS file * When two or more blocks, only the filled form display messages (error or success) * Fix review comments * Build assets * Changed the exception for catching only this one * Moved the exception * Make sure legacy env is 'test' for behat tests instead of 'dev' * Remove reference to non existent css file * Fix for #15308 * Revert "Fix for #15308" This reverts commit 81076b6. * Revert "Revert "Fix for #15308"" This reverts commit 67f0139. * Add category_name to SearchResultProductFilter whitelist, fix [BOOM-4639] / issue 9767 * Updated prestashop/ps_emailsubscription to 2.5.0 * Updated prestashop/ps_facetedsearch to 3.2.1 * Updated prestashop/ps_contactinfo to 3.2.0 * Change Viewport to not test in responsive mode * Replace quantity by quatity_wanted in product data FO * Add faker to create faker products * Check quantity_wanted and not quantity in FO * Add selectors * Add functions needed * Add new page for product form * Add sanity tests productsBO * Typo and avoid card-block border show Unclosed p tag and hide card-block padding and note when store note is empty * Update name of test Co-Authored-By: Simon Garny <49909275+SimonGrn@users.noreply.github.com> * Add extension to file * Add extension to file * change caps for filterBy * Add update addProduct page * Add way of using caps in tests * Update way of using caps in tests * Add quantity and price as arguments * fix esLint errors * Changing the way of getting number of products * Fix breadcrumb SEO The PullRequest #14710 causes structured data to no longer be valid. * Fix duplicate retrieval of attributes color list * Add cart rule command with relevant VOs * Fix namespaces and add unit tests * Add more unit tests for cart rule action builder * Implement add cart rule handler * WIP behat tests * Add behat tests for percentage and amount cart rules creation, update unit tests, fix bugs in handler/command * Fix cs * Improve error message * Try resetting object model cache in behat * Fix object model cache in behat * Updates after code review * Cleanup behat tests * Remove unused method * Move hardcoded legacy values to constants * Cleanup code * Disable object model cache before all domain test suites * Fix tests names to respect naming conventions * Renaming filterOrder file * Delete some empty lines * Add catalog FO tests * Fix some issues * Update PaymentModule.php * Escape Employee email * Modified versions in composer.json * Introduce more tools to test env * Modified versions in composer.json * Update faker to add combinations * Add global functions * Add functions in addProduct Page * Update name of test * Rename file * Create new tests CRUD products with combinations * Rename directory of tests productsBO * Replace parseFloat by parseInt * Fix codestyle * Rename file product to products for BO Products page * Update Postal Code of South Korea * Change way to generate data with faker * Fix eslint errors * Fix eslint errors * Update License Headers Updater command * Add productName to faker product class * Add selectors and functions fot delete product * Add 2 SanityTests To test deleting products * Add var settingUpdatedMessage * Update name of var * Fix license headers * Update License Headers Updater command * Fix codestyle * Finalize Update License Command * Give more memory to php-cs-fixer * Add tests for cart fo * Use the common function * Add async/await and add a timeout variable * Add the param timeout in the description * Add some comments * Set the browser in the English language * Fix lint errors
Hi! Your pull request description seems to be incomplete or malformed:
Would you mind completing the contribution table ? This would help us understand how interesting your contribution is. Thank you! (note: this is an automated message, but answering it will reach a real human ) |
prestonBot
added
Bug
Type: Bug
Waiting for wording
Status: action required, waiting for wording
labels
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding autoUpgrade module Page
Adding selectors to homePage
Adding test UpgradeShop
Fix grids data when in single shop context
Fix productWOImages grid show default shop in allShopContext
Adds missing
where
statement in products sql queryFix lint
Integrate perfet-scrollbar for new-theme
Integrate perfect scroll on default them
Build assets
Remove another faulty e2e test from Travis
Adding env argument and use it in Upgrade test
Adding expect in autoUpgrade Page
Separate services tests and Prestashop
New docker file and docker compose for version 1.7.5.2
Delete docker-compose
fix issue [BOOM-5380] Can not search a disabled product after enabling it from product list #9663
Disable e2e Travis builds for now
Get image from prestashop-git
Change command to run docker_run_git.sh (composer install)
Changing name of dockerfile in docker-compose
Adding Env variable PS_VERSION
Checkout to specific version if env var is not empty
change file to a dockerfile
Fix translations interface
Build assets
Deleted unused private method
Rename file ps-git to Dockerfile-from-git
Rename PS_VERSION to PS_VERSION_TO_INSTALL
Add PS_VERSION env variable used in upgrade test
Remove Docker from README add add DOCKER.md file
Add upgrade test to README
Fix bug when getting currency name containing localiazed names
Add method to CurrencyDataProviderInterface to allow fetching all available currencies
Fix command in DOCKER.md
Fix QA comments
Apply CS fixer
Builds assets
feat: remove clear email
make email display optional
Add space betwenn lines in Docker.md
Rename methods/parameters and add optional parameter instead of new method
Fix the product selector in the FO
Add the class name in the selector
Increase timeout to wait Prestashop to 720s
updated
Add hook to display the address extra added fields
This hook will helpful to display the content added as an extra field in the address block.
fix issue [BOOM-5380] Can not search a disabled product after enabling it from product list #9663
updated
Fix filtering by customer
Update invalid characters in Customer Creation & Update error messages and tips
Move code for cleaning character in its own class and remove methods in Tools Adapter
Fix wording
Use ContainerFinder
Added a debug_print_backtrace for Travis
Sort smoke tests by adding number to the names
Modified the method for calling directly the class if no container is available
Removed the debug_print_backtrace and caught the exception in ContainerFinder
// Changelog 1.7.6.1
Change .sr-only hidden span to aria-label
#15083
https://www.w3.org/TR/WCAG20-TECHS/ARIA14.html
All have 2 except the last one.
Use a different way to sort order products
Remove useless code
Remove foreach and update string indentation
Move it into two requests because on some engine update order on multiple tables is not working
Add comments to explain why there are two requests
Remove outdated comment
Checked the case where there are no point
Renaming data names
Fixed the unit test and added some case
Modified a comment
Fixed Coding Style errors
Adds behat for creating cms page
behat for create CmsPage comand
Adds behat for delete cms page
Adds some create/edit with invalid data cases
Refactor cms tests for less code duplication
Optimize to use array instead of TableNode when getting creation data
Clarifies cms to CMS
Tiny code cleaning
Get Configuration from container instead of static legacy object
Removes some cases that belongs to units, Adds bulk status toggle behats
Adds bulk enable and bulk delete behats
Removes unnecessary spacing
Removes deleting by id, uses reference instead. Some optimizations, start using PrimitiveUtils
Add storage clearing after cmsPageRemoval
Fix cmsCategory check of null
Sanity tests orderBO
Classic Theme : Plugin EmailSubscription : override the template for column
Fix the class in SCSS file
Fix the class in SCSS file
When two or more blocks, only the filled form display messages (error or success)
Fix review comments
Build assets
Changed the exception for catching only this one
Moved the exception
Make sure legacy env is 'test' for behat tests instead of 'dev'
Remove reference to non existent css file
Fix for Color name doesn't appear over the color block in the product pages #15308
Revert "Fix for Color name doesn't appear over the color block in the product pages #15308"
This reverts commit 81076b6.
This reverts commit 67f0139.
Add category_name to SearchResultProductFilter whitelist, fix [BOOM-4639] / issue 9767
Updated prestashop/ps_emailsubscription to 2.5.0
Updated prestashop/ps_facetedsearch to 3.2.1
Updated prestashop/ps_contactinfo to 3.2.0
Change Viewport to not test in responsive mode
Replace quantity by quatity_wanted in product data FO
Add faker to create faker products
Check quantity_wanted and not quantity in FO
Add selectors
Add functions needed
Add new page for product form
Add sanity tests productsBO
Typo and avoid card-block border show
Unclosed p tag and hide card-block padding and note when store note is empty
Co-Authored-By: Simon Garny 49909275+SimonGrn@users.noreply.github.com
Add extension to file
Add extension to file
change caps for filterBy
Add update addProduct page
Add way of using caps in tests
Update way of using caps in tests
Add quantity and price as arguments
fix esLint errors
Changing the way of getting number of products
Fix breadcrumb SEO
The PullRequest #14710 causes structured data to no longer be valid.
Fix duplicate retrieval of attributes color list
Add cart rule command with relevant VOs
Fix namespaces and add unit tests
Add more unit tests for cart rule action builder
Implement add cart rule handler
WIP behat tests
Add behat tests for percentage and amount cart rules creation, update unit tests, fix bugs in handler/command
Fix cs
Improve error message
Try resetting object model cache in behat
Fix object model cache in behat
Updates after code review
Cleanup behat tests
Remove unused method
Move hardcoded legacy values to constants
Cleanup code
Disable object model cache before all domain test suites
Fix tests names to respect naming conventions
Renaming filterOrder file
Delete some empty lines
Add catalog FO tests
Fix some issues
Update PaymentModule.php
Escape Employee email
Modified versions in composer.json
Introduce more tools to test env
Modified versions in composer.json
Update faker to add combinations
Add global functions
Add functions in addProduct Page
Update name of test
Rename file
Create new tests CRUD products with combinations
Rename directory of tests productsBO
Replace parseFloat by parseInt
Fix codestyle
Rename file product to products for BO Products page
Update Postal Code of South Korea
Change way to generate data with faker
Fix eslint errors
Fix eslint errors
Update License Headers Updater command
Add productName to faker product class
Add selectors and functions fot delete product
Add 2 SanityTests To test deleting products
Add var settingUpdatedMessage
Update name of var
Fix license headers
Update License Headers Updater command
Fix codestyle
Finalize Update License Command
Give more memory to php-cs-fixer
Add tests for cart fo
Use the common function
Add async/await and add a timeout variable
Add the param timeout in the description
Add some comments
Set the browser in the English language
Fix lint errors
Every detail helps: versions, browser/server configuration, specific module/theme, etc.
This change is