Do not check version if not provided #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Hlavtox
approved these changes
Sep 14, 2023
boherm
approved these changes
Sep 15, 2023
djoelleuch
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Hello @matks ,
I have checked your PR the issue is well fixed ,
Untitled_.Sep.18.2023.10_12.AM.webm
It's QA approved ✔️
Thank you for your PR 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the Configuration page of the module is opened, the checklist is being verified. Function UpgradeSelfCheck::checkKeyGeneration() is called but at this moment
$this->upgrader->version_numis NULL so the use of version_compare triggers a warning.At the beginning I was worried about
$this->upgrader->version_numbeing NULL. But then I explored the code and actually I found that$this->upgrader->version_numis set in UpgradeContainer::getUpgrader() and it depends on the channel chosen. The version number variable will be set from different locations if the target version is available on the API, in a file or in a directory. So it makes sense that, when the page is opened, it is not yet set and then it is NULL.So my solution to avoid the warning is simply not to perform the comparison if
$this->upgrader->version_numis NULL as this is a valid usecase.