Remove usage of unused code #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Nov 23, 2023
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | All of this code is completely unused and can be safely removed. |
| Type? | refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| Sponsor company | |
| How to test? | Tests green are sufficient. If you want, you can upgrade from 1.7.6.9 to 8.1.2. If it goes normally (with normal issues. :)), it's OK. |
ShaiMagal
approved these changes
Nov 23, 2023
Merged
|
Hi @Hlavtox Thank you for your PR, I tested it and it seems to works as you can see : Untitled_.Nov.29.2023.3_40.PM.webmThe PR seems to works as expected, It's QA ✔️ Thank you |
AureRita
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.