Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failsafe require and add first working version of 1.7 in automatic tests #688

Merged
merged 9 commits into from
Apr 22, 2024

Conversation

ga-devfront
Copy link
Contributor

@ga-devfront ga-devfront commented Apr 9, 2024

Questions Answers
Description? If you try upgrading from 1.7.1.0 to a version below 1.7.3.0, you get an error about AppKernel because this class is not present in the core autoload classmap. This PR adds:
  • A safety net while loading AppKernel
  • Expands the tested versions of PrestaShop in CI,
  • Improved the readability of the base version running the shop in CI.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? NA
Sponsor company @PrestaShopCorp
How to test? Check if CI is green. To check the fix, try upgrading a PrestaShop 1.7.1.0 to 1.7.2.0.

@ga-devfront ga-devfront added the wip label Apr 9, 2024
@Quetzacoalt91 Quetzacoalt91 removed the wip label Apr 16, 2024
@Quetzacoalt91 Quetzacoalt91 changed the title Appkernel require Add a failsafe require and add first working version of 1.7 in automatic tests Apr 16, 2024
M0rgan01
M0rgan01 previously approved these changes Apr 17, 2024
@M0rgan01 M0rgan01 added this to the 5.0.2 milestone Apr 17, 2024
@AureRita AureRita self-assigned this Apr 18, 2024
@AureRita
Copy link

Hi @ga-devfront

Thank you for your PR, Currently I tried to upgrade to 1.7.3.0, I don't have the App Kernel but when i'm on 1.7.3.0 I only have blanck page as you can see :

recording.193.webm

Did I miss something ?

Waiting for your correction

Thank you

@Quetzacoalt91
Copy link
Member

@AureRita this is likely caused by the issue fixed in #690, let me rebase so you try again.

@AureRita
Copy link

Hi @ga-devfront

I have the same things that previously as you can see :

recording.196.webm

Waiting for your correction

Thank you

@ga-devfront ga-devfront dismissed M0rgan01’s stale review April 22, 2024 09:26

The merge-base changed after approval.

Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ga-devfront

After other research, I know that this issue is not due to your PR.

Your PR correct the issue on the App Kernel.

I tested on :
1.7.1.0 to 1.7.8.11 from minor release
8.0.3 to 9.0.0 to check the non regression

Because the PR seems to work as expected, it's a QA ✔️

Thank you

@ga-devfront ga-devfront merged commit 633c48b into dev Apr 22, 2024
58 checks passed
@ga-devfront ga-devfront deleted the fix/appkernel-required branch April 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants