-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a failsafe require and add first working version of 1.7 in automatic tests #688
Conversation
ga-devfront
commented
Apr 9, 2024
•
edited by Quetzacoalt91
Loading
edited by Quetzacoalt91
Questions | Answers |
---|---|
Description? | If you try upgrading from 1.7.1.0 to a version below 1.7.3.0, you get an error about AppKernel because this class is not present in the core autoload classmap. This PR adds:
|
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | NA |
Sponsor company | @PrestaShopCorp |
How to test? | Check if CI is green. To check the fix, try upgrading a PrestaShop 1.7.1.0 to 1.7.2.0. |
Hi @ga-devfront Thank you for your PR, Currently I tried to upgrade to 1.7.3.0, I don't have the App Kernel but when i'm on 1.7.3.0 I only have blanck page as you can see : recording.193.webmDid I miss something ? Waiting for your correction Thank you |
d564469
to
491a354
Compare
Hi @ga-devfront I have the same things that previously as you can see : recording.196.webmWaiting for your correction Thank you |
491a354
to
c42eb6a
Compare
…d after installation
The merge-base changed after approval.
c42eb6a
to
bf4d383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ga-devfront
After other research, I know that this issue is not due to your PR.
Your PR correct the issue on the App Kernel.
I tested on :
1.7.1.0 to 1.7.8.11 from minor release
8.0.3 to 9.0.0 to check the non regression
Because the PR seems to work as expected, it's a QA ✔️
Thank you